On Tue, Nov 22, 2016 at 09:37:20AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 21, 2016 at 10:29:15PM +0200, Jarkko Sakkinen wrote: > > > I just went through tpm_bios_log_setup(), tpm_read_log_of() and > > tpm_read_log_acpi(). The error handling is sound now but the condition > > should be in tpm_bios_log_setup(). Not in tpm_chip_register(). > > > > It is applied but if you don't mind I would like make a small commit > > that moves the condition to that function. > > I'm not particularly concerned where the check lives..
It's just a minor glitch but still an obvious inconsistency. Maybe I'll ignore for th moment as everything is well tested. There is still two commits in the series that are untested and unreviewed. /Jarkko ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
