On Tue, Nov 22, 2016 at 08:07:42AM +0200, Jarkko Sakkinen wrote: > On Sat, Nov 19, 2016 at 11:32:55AM -0700, Jason Gunthorpe wrote: > > On Thu, Nov 17, 2016 at 06:15:20PM -0500, Stefan Berger wrote: > > > > > >>Further, I had the impression that the error unwinding following > > > >>-ENODEV has > > > >>an issue related to sysfs. > > > >I don't follow this comment.. > > > > > > I have encountered this error here, which gets masked when applying the > > > previously shown patch. > > > > If tpm_chip_register fails vtpm must not call tpm_chip_unregister: > > > > > [ 58.271017] [<ffffffff8155bd32>] dpm_sysfs_remove+0x22/0x60 > > > [ 58.271017] [<ffffffff8154e438>] device_del+0x58/0x280 > > > [ 58.271017] [<ffffffffa024c020>] tpm_chip_unregister+0x40/0xb0 [tpm] > > > [ 58.271017] [<ffffffffa0292360>] vtpm_proxy_fops_release+0x40/0x60 > > > [tpm_vtpm_proxy] > > > > So, this is a vtpm thing I missed for 'tpm: Get rid of > > TPM_CHIP_FLAG_REGISTERED' > > > > Does this do the trick? > > Tested-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> /Jarkko ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
