> -----Original Message----- > From: Alan Cox [mailto:gno...@lxorguk.ukuu.org.uk] > Sent: Thursday, June 8, 2017 11:50 AM > To: Jason Gunthorpe <jguntho...@obsidianresearch.com> > Cc: Shaikh, Azhar <azhar.sha...@intel.com>; > jarkko.sakki...@linux.intel.com; tpmdd-devel@lists.sourceforge.net; linux- > ker...@vger.kernel.org; linux-security-mod...@vger.kernel.org > Subject: Re: [PATCH v3] tpm: Enable CLKRUN protocol for Braswell systems > > > For that purpose all that should be required is strong ordering of the > > outb relative to the other TPM commands at the LPC interface FIFO. I > > also think the wmb is not needed because outb is already defined to be > > strongly in order with respect to writel/readl ? > > That's my assumption but given this is all some kind of 'it's broken' > fixup I thought best to ask. Assuming there is nothing else magical going on > then yes it should be deleted. >
As Jason mentioned, outb is already define to be strongly ordered, then wmb is not needed. I will delete it. > Alan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
