http://trac.edgewall.org/changeset/4553

Revision 4553 added configuration options for the age-based coloring of
the annotated code.

The get_custom_colorizer method does a lot of parsing of the formatting
for configuration options which I think could be handled by Option
subclasses to separate this logic.  This way if other places happened
to want to use the color-related options they wouldn't also have to
parse the values.  I think a FloatOption would be valid to add to
trac.config.  For the color tuples a custom subclass could be added to
the module (possibly "private" via an "_" prefix).  I think this would
also help the logic under line 149, since that statement could become
"if self.intermediate_point and self.intermediate_value".

Alternatively, the color interpolation could be replaced by a discrete
set of colors in CSS like we do for the priorites.  This way we could
also use even/odd colorings so there's a little contrast between blocks
that fall into the same time range.

-- Matt Good


--~--~---------~--~----~------------~-------~--~----~
 You received this message because you are subscribed to the Google Groups 
"Trac Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to