Am 25.01.2007 um 07:58 schrieb Jeroen Ruigrok/asmodai:
> -On [20070124 15:28], Christopher Lenz ([EMAIL PROTECTED]) wrote:
>> I think we should just use "render_macro2" in this case.
>
> If you talk about API design I consider these kind of names the
> worst you
> could use. It is not descriptive in the manner that it doesn't explain
> immediately the difference between render_macro and render_macro2.
I don't agree. Assume the interface:
class IWikiMacroProvider(Interface):
def get_macro_names(): ...
def get_macro_description(name):
def render_macro(req, name, content): ...
def expand_macro(formatter, name, content): ...
Does that somehow indicate that the methods render_macro() and
expand_macro() are the same thing, one being deprecated in favor of
the other? No! s/expand_macro/render_macro2 and the picture becomes
clearer. Both methods have the exact same purpose, but incompatible
signatures. Trying to find a different name for a method that does
the same thing conceptually as another method will not help clarify
the difference, because again, they don't actually have different
purposes.
But anyway, as Christian noted, we agreed on using "expand_macro"
yesterday on IRC.
Cheers,
Chris
--
Christopher Lenz
cmlenz at gmx.de
http://www.cmlenz.net/
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
