Jeroen Ruigrok/asmodai wrote: > -On [20070124 15:28], Christopher Lenz ([EMAIL PROTECTED]) wrote: > >> I think we should just use "render_macro2" in this case. >> > > If you talk about API design I consider these kind of names the worst you > could use. It is not descriptive in the manner that it doesn't explain > immediately the difference between render_macro and render_macro2. >
Well, now it's `expand_macro` anyway, not really better about hinting what the change is :) `format_macro` would have been better in that respect, as one could imagine there would be a formatter argument there, but it had other issues (the verb doesn't really apply to the subject). Now that we're brainstorming about method names, I'd like to hear suggestions about a better name for `parse_macro` (i.e. the IWikiMacroProvider callback that will be called by the parser after the parsing stage), as it has the same issue as 'format_macro' had. Though not "grammatically optimal", parse_macro and format_macro would have been clear... -- Christian --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
