Eli Carter wrote: > On Monday 30 April 2007, Alec Thomas wrote: >> Err, in case this wasn't clear, I'm suggesting we delay the merge >> until more people have reviewed it. >> >> On 5/1/07, Alec Thomas <[EMAIL PROTECTED]> wrote: >>> On 5/1/07, Christian Boos <[EMAIL PROTECTED]> wrote: >>>> Eli has put the WorkFlow branch in a good shape, and it has been quite >>>> usable for a while now. I've taken a look, tested it and all seems well >>>> for me for shifting the work on trunk where it could gain some wider >>>> exposure. So I'd like to call a vote for the merge. >>>> >>>> The ideal situation would be to get a few +1 besides mine and Eli's, >>>> till tomorrow afternoon, as it's the 1st of May and I'll have some time >>>> to work on the merge together with Eli. But otherwise, it's not a big >>>> deal, as I've got plenty of other areas to hack on ;-) >>> This is not picking on Eli at all, but can we get more review before >>> doing major merges? I'd personally like to see at least one of cmlenz, >>> jborg or mgood comment on major merges *before* they go in. The more >>> people that look at the code the better it will be. Different minds >>> pick up different issues. > > Agreed. Review is definitely welcome. The problem is it seems to require a > threat of merging before it happens. :( >
I've been looking at the code now and this branch seems to be in pretty good shape. I've just found some minor code formatting issues but nothing that can't be addressed in trunk later. So +1 from me. Cheers, Jonas --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
