On Thursday 17 May 2007, Christian Boos wrote:
> 
> Eli Carter wrote:
> > Patch applied to the branch, thanks. :)
> > That looks much better.  However, the amount of vertical whitespace is a 
bit 
> > much, I think.
> >   
> 
> Ok, I've fixed that in r4506. I was somehow surprised about how my Opera 
> browser was behaving while tweaking the stylesheet. I hope the change 
> doesn't disturb too much the other browsers (works fine in FF, IE7 and Op9).

Ah, much better.  Thanks!  (konqueror here)

> >>>>  - the list of checkboxes for selecting the columns is a bit too 
intrusive
> >>>>         
> >>> Yeah, it's not real pretty.  For javascript-enabled clients, making it a 
> >>> collapsable box would probably be a small step in the right direction.  
> >>> Otherwise, do you have a suggestion on how that could be presented 
better?
> >>>   
> >>>       
> >> Without javascript, I would prefer to have the list of fields below the 
> >> table, if possible.
> >>     
> >
> > To customize my query, I don't want to have to scroll to the bottom of the 
> > page.
> >   
> 
> Ok, see r4508-4509.
> Looks good enough for a merge.

The collapsable boxes look great.  Thanks! :)

I'll merge sometime today.

Small nit for the previous patch (in [5405]), you changed the API for rows 
from rows=None to rows=[]; but didn't make the same change for cols.  Any 
particular reason for that?

Eli

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac 
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to