On Thursday 17 May 2007, Christian Boos wrote: > > Eli Carter wrote: > > I'll merge sometime today. > Good! Then we can continue with the time fields.
Merged. > > Small nit for the previous patch (in [5405]), you changed the API for rows > > from rows=None to rows=[]; but didn't make the same change for cols. Any > > particular reason for that? > > It was interesting for rows, in order to keep the append() done just > after simple, but not really needed for cols. > Besides, the "rows" argument was a new addition to the API so changing > it wouldn't break anything ;-) > For cols, it's quite likely that there exists code setting it explicitly > to None, so changing it now is perhaps not a good idea. Fair enough for now. At some point, we may want to revisit that API. Hmmm.... I'm seeing an odd visual artifact here.... 1. go to custom query 2. add a filter 3. update 4. expand columns box 5. remove a filter 6. note the duplication of the columns box header Hmm... works fine in Firefox, so it looks like this is a Konqueror bug. Eh. Eli --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
