Jeroen Ruigrok van der Werven wrote:
> Why is notification.py's style for use of TracError so different from other
> files?
>
> Compare
>
> raise TracError, 'Invalid email encoding setting: %s' % pref
>
> as opposed to
>
> raise TracError('No upgrade module for version %i (%s.py)' % (i, name))
>
> For the i18n work I need to rework this to
>
> raise TracError(_('No upgrade module for version %i (%s.py)' % (i, name)))
>
> I just wonder why the styles are inconsistent. :)
>
>
Getting to the constructor call style for raising TracError (and other
exceptions) was a gradual process, and it might well be that there are
still (a few) old-style raise statement. You're welcomed to fix those,
but as usual for the i18n branch, please consider making any non-i18n
infrastructure related change on trunk /first/, as to avoid possible
merge issues. Btw, how went that last little merge? ;-)
-- Christian
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
