[email protected] wrote: > Hello, if it is ok, I would like to contribute, especially to version 0.12. > I'm mostly familiar with the wiki code, so I guess the Rename stuff would be > most appropriate for me, especially since I did a little related work in > #8453 (something that will never get included and no one but me will probably > use). >
Great! Your help would be welcome. > So, if anyone gives me a nod to start doing this, then I'll start. If there > is any info that I might need that isn't online ... I mean, there is an > existing branch, but that seems to be pretty idle. > Well, it's idle because it's finished ;-) When I was done with that branch, the wiki rename feature was working quite well, in a robust way. There was some negative reactions at the time I proposed it for integration into trunk, because some people didn't like the `transaction` helper function I mixed in there (note in passing that by using such a helper consistently for performing commit/rollback on SQL transactions instead of relying on the gc for the eventual rollback, we wouldn't have the occasional "current transaction is aborted" error). So the idea would be to redo the changes on current trunk, minus the transaction code if people are still adverse to it (i.e. omitting http://trac.edgewall.org/changeset/7333). This means redoing r7334 using the current style (with a handle_ta flag), then adapt r7335, r7336, r7337, r7738 and r7339 (r7340 and r7941 will be skipped as well). Best would be a sequence of cumulative patches for each of the above changes. Don't hesitate to ask for more details, as you need them. Depending how well this first phase go, we could even push things a bit further (like the batch rename idea in http://trac.edgewall.org/ticket/4412#comment:8). But if you're OK with that approach, let's focus on the above rebasing and simplifying first. -- Christian --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
