Christian Boos wrote:
> (1) in particular, the SQL queries are very nicely presented, e.g.
> 
> 13    cursor.execute("""
> 14                SELECT value, authenticated
> 15                  FROM session_attribute
> 16                 WHERE sid=%s
> 17                   AND name=%s
> 18            """, (sid, 'email'))
> 
> We should do that in the rest of Trac as well ;-)

(OT) We're not far from that, are we? Except that we use the "string
concatenation" style:

  cursor.execute("SELECT value, authenticated "
                 "FROM session_attribute "
                 "WHERE sid=%s AND name=%s",
                 (sid, 'email'))

I wouldn't be against switching, though. It would allow avoiding too
much indentation of SQL queries, and keep the quotes where we can see
them ;-)

-- Remy

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to