On Tuesday, August 23, 2016 at 1:16:05 PM UTC-7, Tim Graham wrote: > > Hi, > > I wonder if there's any objection among the Trac team for moving toward > accepting pull requests on GitHub? Is there a reason you prefer attaching > patches to tickets instead? Django used to only accept patches that way, > but since we started accepting pull requests some years ago, anytime > someone uploads a patch to Trac, I ask if they can create a pull request > instead. The ability to leave inline comments makes code review much easier > and we also have continuous integration with Jenkins to automatically run > the tests on each patch. > > I've thought of trying to setup continuous integration for Trac using > Travis unless there's already a system in place that I don't know about or > if someone knows of a reason why Travis wouldn't work. I'd like to help > with the Python 3 effort soon, but I think we'll need to use GitHub for > review and it would be nice to have automated tests too. > > Thanks, Tim >
You are welcome to fork the GitHub mirror and provide your patches through a branch in your forked repository. That will allow us to use GitHub's commenting mechanism as well. Several contributors (0) have used that process and it's the process I used before I was given write access. I need to update TracDev/SubmittingPatches (1) to describe the process. Trac runs tests on TravisCI and AppVeyor (2). I push my changes to my forked repository on GitHub to run the builds (3). The only part of your suggestions which we don't already use is the GitHub pull requests module. To use pull requests, we'd either need to host our repository on GitHub, or implement 2-way synchronization rather than simple mirrors. I've suggested we could do that latter using SubGit, but I haven't found time to set it up. Or we could just move our repository from SVN to Git. I like the idea of using SubGit. I've used it elsewhere and found it to be very robust. - Ryan (0) https://trac.edgewall.org/ticket/7628#comment:24 (1) https://trac.edgewall.org/wiki/TracDev/SubmittingPatches (2) https://trac.edgewall.org/wiki/TracDev/AutomaticBuilds (3) https://travis-ci.org/rjollos/trac/builds -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-dev+unsubscr...@googlegroups.com. To post to this group, send email to trac-dev@googlegroups.com. Visit this group at https://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/d/optout.
