Yes, it's some effort to keep the state of tickets and pull requests in sync. We have a "Has patch" field on our tickets as well as flags like "Patch needs improvement", "Needs documentation", "Needs tests". The ticket review queue is the tickets that have "Has patch" checked without any of the "Needs improvement" flags. After I review a pull request, I'll check the "Needs improvement" flag and ask the contributor to uncheck it after they update the PR.
Look at https://code.djangoproject.com/ticket/27089 and search for "Pull requests:" The code that generates that is https://github.com/django/code.djangoproject.com/blob/669bc946bdd378fa6e086acb3e8af80bfd319eb9/trac-env/htdocs/tickethacks.js#L99-L208 On Tuesday, August 23, 2016 at 8:56:44 PM UTC-4, RjOllos wrote: > > > > On Tuesday, August 23, 2016 at 1:58:43 PM UTC-7, Tim Graham wrote: >> >> Great, thanks for the info. About pull requests, I was thinking that you >> could create them in the mirror's queue ( >> https://github.com/edgewall/trac/pulls), it's just that a commiter must >> merge the PR locally similar to what's described here: >> https://docs.djangoproject.com/en/dev/internals/contributing/committing-code/#handling-pull-requests >> > > It's worth considering. However, unless we developed a plugin or feature > that could present those PRs in the ticket view, I tend to think it would > probably just be more effort to manage the PRs since we don't currently do > any work from GitHub. > > This caught my attention when reviewing the Django guidelines: > > "Since you can’t push to other contributors’ branches, comment on the pull > request “Merged in XXXXXXX” (replacing with the commit hash) after you > merge it. Trac checks for this message format to indicate on the ticket > page whether or not a pull request is merged." > > I was looking for an example of that, but couldn't find one after > reviewing a few dozen tickets on the Django site. Could you point me to an > example? > > Thanks, > - Ryan > -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-dev+unsubscr...@googlegroups.com. To post to this group, send email to trac-dev@googlegroups.com. Visit this group at https://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/d/optout.
