Greg, I would prefer to see a plugin which uses 'svn diff' so that the 'merge cops' can review the differences and add comments to each change made. These comments can then be considered by the developer, and taken care of before an updated changeset is submitted for review. Once the review, and all outstanding comments are accepted by all concerned, then it can be committed to the trunk or branch, but not until all comments made have been taken care of.
If anybody is developing a plugin for Trac they should try to design it so that it meets their needs as well as the needs of other Trac users. Hopefully you will get more feedback from other Trac users and be able to get the help you need, and feedback for your design. Thanks, Tim -----Original Message----- From: [email protected] [mailto:[EMAIL PROTECTED] On Behalf Of Greg Dickie Sent: 03 October 2006 17:27 To: [email protected] Subject: [Trac] plugin for code review Hi, I'm contemplating creating a plugin to implement our "merge police". Basically developers work in their own private branches (keeping them in sync with the main project branch) until they are ready to have it merged back into the project branch. At that time they request the merge and the code goes to one or more "merge cops" to review. If it gets approved then a cron job automatically merges the developer branch back to the project branch. I had this all working beautifully at my previous employer and would like to leverage trac to do it now. Unfortunately my python skills are pretty weak at the moment. I have seen the peer review plugin on trac-hacks but the workflow is not really appropriate for us plus it doesn't appear to work in the latest trac..... Does anyone have any words of wisdom or have the done something similar? Is trac the right way to go for this? Thanks alot, Greg -- Greg Dickie just a guy Maximum Throughput --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Users" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-users -~----------~----~----~----~------~----~------~--~---
