On Oct 15, 11:14 am, Jani Tiainen <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] kirjoitti: > > > > > On Oct 7, 4:40 am, Jani Tiainen <[EMAIL PROTECTED]> wrote: > >> I've trying to search for plugin for code reviewing and there exists at > >> least one in trac-hacks. It's just not user friendly - you can't just > >> select change set(s) to be reviewed, you have to manually create in > >> separate user interface what lines you want to review from what file. > > >> There exists few external tools and Review Board seems one of > >> interesting ones - specially since it has JSON interface to be interact > >> with. Now, is anyone tried to make it work with Trac so at least sending > >> new reviews could be done from Trac repo browser? > > >> -- > >> Jani Tiainen > > >> "Tein sein mihin näillä lahjoilla pystyin. > >> Tein sen, en yhtään enempää." - Martti Servo & Napander > > > It would seem to me the XMLRPC interface would be perfect for this, > > combined with a "code review" ticket type, or workflow step. > > > question is, any code review apps that support xmlrpc out there? > > Well Review Board that I mentioned has JSON interface... Just curious, > what kind of a workflow you had in mind... > > I think it might be relatively easy to do some integration between these > two... Specially that "code review" tickettype/workflow step sounds very > interesting. > > -- > > Jani Tiainen
Well for us, for example, we have a modified version of the "enterprise" workflow. a developer "resolves" a ticket as fixed, invalid, etc... we then have a "verified" step. For our Design Practices, part of the verification includes a code review when applicable. Each ticket has a special "ReviewedBy" field with Not Required, Required, and a list of people that reviewers (which is the whole department) While not ideal, it does the job. The limitations are that it can only have 1 reviewer in this model ,and in reality we often like to have multiple reviews. The history is also only stored in trac's db, when really I would like it checked into the repo somewhere, maybe in a "code reviews" directory. It also gets a little clunky with our branching/ merging strategy. Re-integration to the main branch for us is a function of a master ticket which is the parent of all tickets in a feature branch. So...the code review currently is on the feature branch changes, and not the merged result. I am not really sure what is better there. Anyway, it would be a short putt to put in a separate "codeReview" step in our workflow between "resolved" and verified, or even prior to resolved. (there is the classic chicken/egg debate on WHEN to do a code review here) An external tool that could be used to do the review, put the review results into the repository, and update the ticket to point to the review, combined with a "code review" ticket type, and maybe a special report/view page would do the trick. If that external tool could also pull the "code reviews required" list or the "code reviews assigned to me" list that would be nice also. or something. Seems like an explicit "code review" work-flow stage would be nice anyway. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Users" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-users?hl=en -~----------~----~----~----~------~----~------~--~---
