On Oct 20, 9:54 am, [EMAIL PROTECTED] wrote: > On Oct 15, 11:14 am, Jani Tiainen <[EMAIL PROTECTED]> wrote: > > > > > [EMAIL PROTECTED] kirjoitti: > > > > On Oct 7, 4:40 am, Jani Tiainen <[EMAIL PROTECTED]> wrote: > > >> I've trying to search for plugin for code reviewing and there exists at > > >> least one in trac-hacks. It's just not user friendly - you can't just > > >> select change set(s) to be reviewed, you have to manually create in > > >> separate user interface what lines you want to review from what file. > > > >> There exists few external tools and Review Board seems one of > > >> interesting ones - specially since it has JSON interface to be interact > > >> with. Now, is anyone tried to make it work with Trac so at least sending > > >> new reviews could be done from Trac repo browser? well, I checked out ReviewBoard. Nice looking tool, I can see the attraction to try and get this working with trac. I also was reading and seems like it might take a lot to actually get it working right under some instances (for example, I am on windows, seems to be a bit of a pain). It also uses Django, so that is a separate web framework, we already have Trac. Still, it sure looks nice and well thought out.
I have been playing with the idea of just adding code reviews as svn properties to files. This might be fairly reasonable to add to trac, just not sure of hte format, I would propose a property like crN where N is auto incremented followed by and xml string say <Review><Reviewer>blah</Reviewer><comments>Wiki formatted blah</ comments><action class="accept"/><Other_configurable_fields/></Review> then use the ticket system to actually assign review request, maybe with a special "Reviews" page and special permissions like "REVIEW_VIEW" to view that page and "REVIEW_MASTER" to assign/reject/ create reviews. That zoom.quiet tool linked to in here could be a good starting point? Or maybe intergrating ReviewBoard is the way to go. could be use a plug-in to view/assign code reviews and glue to tickets. I know slickEdit has some code review capabilites too. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Users" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-users?hl=en -~----------~----~----~----~------~----~------~--~---
