On 5/5/10, Remy Blank <[email protected]> wrote:
> Olemis Lang wrote:
>> I'm the current maintainer, that's why I'm concerned ;o)
>
> Oh, right, sorry :)
>
>> The way I see it, the only thing that's missing are admin panels to
>> manage hooks for different VCS hooks (and even in that case further
>> work is needed for multi-repository support).
>
> The file to be edited will differ from backend to backend.
That's accurate. RepositoryHooksPlugin extensions are different from
the ones committed to trunk (and the architecture is slightly
different as well ;o). Below a comparison of interfaces (names might
not be accurate since I don't have source code at hand right now :-S )
|| RepositoryHookSystem || Trac 0.12b ||
|| IRepositoryHookSubscriber (VCS agnostic) || IRepositoryChangeListener ||
|| IRepositoryChangeListener (VCS specific) || ||
|| IRepositoryHookSetup || ||
|| IRepositoryHookAdminContributer || ||
|| IRepositoryHookSystem (mix-in ;o) || ||
RepositoryHookSystem might be a bit more powerful as well 'cause it
supports multiple hooks (currently SVN pre | post | * commit hooks )
and even builds «fake» changeset objects when needed (e.g. SVN
pre-commit hooks) . BTW:
- The version in trunk works just for post-commit
(or equivalent) hooks, or any hook and any VCS ?
> Even worse,
> some backends (e.g. Mercurial) allow specifying hooks in several locations.
>
Even worse ? Even better from (my | user) perspective ! More options
at hand . In fact you got me, I was about to start an implementation
for Hg soon ;o)
PS: I got your point ...
> My feeling is that this is better left in a plugin, in the same way as
> IniAdminPlugin and CustomFieldAdminPlugin. But that's only me.
>
Ok , so it's possible to start a 0.12 branch and implement this kind
of things in there (for 0.12). However it would be very nice if Trac
Team could backport repos hooks to 0.11 . Doing so the plugin could
focus on providing those aspects not covered by mainstream hooks
implementation . E.g. for some reason both approaches are different
(especially interfaces ;o) so it would be nice to make both solutions
more interoperable so that hook actions (components) may be written
once and used with both Trac 0.11 and 0.12 . Today that's not possible
'cause they are substantially different, different imports, ...
Since the backport might never happen , what could be done to route
both the plugin and Trac versions in the same direction ?
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
--
You received this message because you are subscribed to the Google Groups "Trac
Users" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/trac-users?hl=en.
