Olemis Lang wrote: > - What about supporting this for 0.13 (at least the SVN impl > and the extension point for third party plugins ;o) ?
As the name implies, an `IRepositoryChangeListener` listens for repository *changes*. A pre-commit hook doesn't inform of a repository change, so it's a bit outside of the intended scope. > - What about adding a hook parameter to trac-admin > command ? I mean, with Mercurial and DVCS, similar > hooks might be invoked on different similar events (i.e. > not all for all events). I don't understand what you mean... > - If so , what'd be the (best | right) way to actually veto > the target changeset ? Your example of vetoing a changeset that doesn't refer to a ticket actually doesn't have anything to do with a Trac repository hook. What you need is to extract any ticket references from the commit message, something you can do with a regexp, and to check if that ticket exists. For this, a `trac-admin $ENV ticket list` command would be useful (possibly with an optional query), but you could also just use a SQL query. > - What's the approach considered for Mercurial plugin ? > Is it gonna be distributed with Trac core (in the future) or > is it that it will always be a separate plugin ? It will remain a separate plugin due to licensing issues (Mercurial is GPL, Trac is BSD). -- Remy
signature.asc
Description: OpenPGP digital signature
