Alec Thomas wrote:
Hmmm, not good. I don't have Postgres installed anywhere, so I can't
really test this unfortunately. If somebody with Postgres installed
could whip up a patch I would be eternally (or at least, briefly)
grateful.

Well, I succumbed to the temptation.  It's actually a very small patch.

In addition to fixing the postgresql support, I also switched it to use the new entry_points style of plugin.

Anyway, here it is. Works for me, though I haven't tested heavily. I was able to upgrade the environment and I now see the new stuff on the wiki pages

-John
diff -urN old-tags-plugin/TracTags.egg-info/trac_plugin.txt new-tags-plugin/TracTags.egg-info/trac_plugin.txt
--- old-tags-plugin/TracTags.egg-info/trac_plugin.txt	2005-09-30 22:56:31.618154000 -0700
+++ new-tags-plugin/TracTags.egg-info/trac_plugin.txt	1969-12-31 16:00:00.000000000 -0800
@@ -1 +0,0 @@
-tractags
diff -urN old-tags-plugin/setup.py new-tags-plugin/setup.py
--- old-tags-plugin/setup.py	2006-03-13 22:53:02.210291000 -0800
+++ new-tags-plugin/setup.py	2006-03-29 15:37:26.207481540 -0800
@@ -8,4 +8,5 @@
     author='Muness Alrubaie',
     url='http://dev.muness.textdriven.com/trac.cgi/wiki/tags',
     description='Tag plugin for Trac',
+    entry_points = {'trac.plugins': ['tractags = tractags']}
     )
diff -urN old-tags-plugin/tractags/api.py new-tags-plugin/tractags/api.py
--- old-tags-plugin/tractags/api.py	2006-03-20 21:38:43.142908000 -0800
+++ new-tags-plugin/tractags/api.py	2006-03-29 15:37:54.506615074 -0800
@@ -288,6 +288,7 @@
             cursor.fetchone()
             return False
         except:
+            db.rollback()
             return True
 
     def upgrade_environment(self, db):
@@ -301,6 +302,7 @@
             self.env.log.debug("tractags needs to migrate old data")
             return True
         except:
+            db.rollback()
             return False
 
     def _upgrade_db(self, db):
_______________________________________________
Trac mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac

Reply via email to