Le lundi 06 novembre 2006 à 00:37 +0000, Jamie McCracken a écrit :
> Laurent Aguerreche wrote:
>
> >
> > All is done.
>
> great - thanks very much!
>
>
>
> > Use --enable-gstreamer (default) or --enable-libxine to use GStreamer or
> > libXine for audio/video metadata extraction.
> > Extractor based on MPlayer did not work on tags like "title", "comment",
> > "album", etc. I updated it and added copyright (Edward and myself).
> > I cleaned up a bit extractor based on Totem but did not test it since I
> > do not have totem-video-indexer on my box.
> >
> > I also removed use of libvorbis, tracker_extract_mp3 and
> > tracker_extract_vorbis.
> > Code implementing tracker_extract_mp3 seems rather buggy (I found
> > channels=0 or wrong duration and wrong bitrate on some files...). And a
> > question about this code : it seems to have received hard work (look all
> > genre_names and addresses to find data in files for instance) but do not
> > mention any copyright... So, is Edward Duffy its unique author or has it
> > been copied from somewhere? In any way, a copyright must be added at its
> > top if we keep it!
>
> It was a quick hack by me from the mp3 code in libextractor - im happy
> to drop it in favour of gstreamer
Ok.
> Have applied but not cleanly as it interfered with other changes I did
> today. Please check its okay (code wise) - it seems to work fine for me.
It seems to work fine for me too :-)
But I see I forgot to change a comment in MPlayer extractor. Could you
apply my patch?
I also wonder if it could be interesting to provide an option
at ./configure to not build Tracker against GStreamer or libXine but to
use external players (MPlayer or Totem).
Laurent.
diff -pruN -x CVS tracker.orig/src/tracker-extract/tracker-extract-mplayer.c tracker.modif/src/tracker-extract/tracker-extract-mplayer.c
--- tracker.orig/src/tracker-extract/tracker-extract-mplayer.c 2006-11-06 01:25:39.000000000 +0100
+++ tracker.modif/src/tracker-extract/tracker-extract-mplayer.c 2006-11-06 02:26:44.000000000 +0100
@@ -39,12 +39,11 @@ static gchar *audio_tags[][2] = {
{ NULL, NULL }
};
-/* Some of "info_tags" tags can belong to Audio or/and video, so 3 cases :
+/* Some of "info_tags" tags can belong to Audio or/and video or none, so 3 cases :
* 1/ tag does not belong to audio nor video, it is a general tag ;
* 2/ tag only belongs to audio ;
- * 3/ tag can belong to audio and video, so we should test if the current media has video, but
- * it would need to find "ID_VIDEO_ID" tag and perhaps go throw each tag to find it... So we
- * decide to duplicate data to Audio and Video.
+ * 3/ tag can belong to audio and video. If current media has video we will associate
+ * tag to Video, otherwise to Audio if it has audio.
*/
static gchar *info_tags[][3] = {
{ "Comment", "Audio.Comment", "Video.Comment" },
_______________________________________________
tracker-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/tracker-list
