Laurent Aguerreche wrote: > Le lundi 06 novembre 2006 à 00:37 +0000, Jamie McCracken a écrit : >> Laurent Aguerreche wrote: >> >>> All is done. >> great - thanks very much! >> >> >> >>> Use --enable-gstreamer (default) or --enable-libxine to use GStreamer or >>> libXine for audio/video metadata extraction. >>> Extractor based on MPlayer did not work on tags like "title", "comment", >>> "album", etc. I updated it and added copyright (Edward and myself). >>> I cleaned up a bit extractor based on Totem but did not test it since I >>> do not have totem-video-indexer on my box. >>> >>> I also removed use of libvorbis, tracker_extract_mp3 and >>> tracker_extract_vorbis. >>> Code implementing tracker_extract_mp3 seems rather buggy (I found >>> channels=0 or wrong duration and wrong bitrate on some files...). And a >>> question about this code : it seems to have received hard work (look all >>> genre_names and addresses to find data in files for instance) but do not >>> mention any copyright... So, is Edward Duffy its unique author or has it >>> been copied from somewhere? In any way, a copyright must be added at its >>> top if we keep it! >> It was a quick hack by me from the mp3 code in libextractor - im happy >> to drop it in favour of gstreamer > > Ok. > >> Have applied but not cleanly as it interfered with other changes I did >> today. Please check its okay (code wise) - it seems to work fine for me. > > It seems to work fine for me too :-) > > But I see I forgot to change a comment in MPlayer extractor. Could you > apply my patch?
thanks have now applied > > I also wonder if it could be interesting to provide an option > at ./configure to not build Tracker against GStreamer or libXine but to > use external players (MPlayer or Totem). > should be okay for now I think unless gstreamer is not portable or something. -- Mr Jamie McCracken http://jamiemcc.livejournal.com/ _______________________________________________ tracker-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/tracker-list
