I'd like to merge it into trunk/master if 1) you could rebase to current master 2) create a clean patch. You have added some 'noise' to your tree that I prefer not to add to master, like you changes to the default databases or the changes to .gitignore. I'd suggest you create a new tree from master and cherry-pick the right patches. I could pull from there. 3) make sure things work for home view, context view and tag view, besides project view. 4) I'd like to see some tests for the new functionality, but we could add it in master too 5) you link a todo to its predecessor by looking for the description of the predecessor. This won't work if you have more than one todo with the same description which we cannot rule out (I've got several todos with the same name in different contexts currently). We need to find a solution to this. See http://github.com/bohrax/tracks/blob/5967a0433b9211916f8291e77d32071e87eac4d 5/app/models/todo.rb#L96 and http://github.com/bohrax/tracks/blob/5967a0433b9211916f8291e77d32071e87eac4d 5/app/models/todo.rb#L114
I hope to find some time to help out with 3) and 5) Reinier > -----Oorspronkelijk bericht----- > Van: [email protected] [mailto:tracks- > [email protected]] Namens Luis Villa > Verzonden: maandag 17 augustus 2009 13:23 > Aan: Henrik Bohre > CC: tracks-discuss > Onderwerp: [Tracks-discuss] Re: Action dependencies merge candidate > > On Sun, Aug 16, 2009 at 5:35 PM, Henrik > Bohre<[email protected]> wrote: > > Hi all, > > > > most readers on this list is probably aware of the dependencies > branch I > > started a while ago. > > > > The latest features include: > > * Add dependencies with drag and drop > > * Hierarchical view of successors > > * Remove dependency with single click (Thanks Reinier!) > > * Improved ajax updates > > > > Just wanted to let you know that I think it's starting to reach a > maturity > > level where it's reasonable to think of merging it into the 1.8 > branch. > > I have not tried the changes of the past 24 hours, nor have I looked > at the code, but from this user's perspective it is definitely > maturing and probably ready for inclusion in trunk. > > Luis > _______________________________________________ > Tracks-discuss mailing list > [email protected] > http://lists.rousette.org.uk/mailman/listinfo/tracks-discuss _______________________________________________ Tracks-discuss mailing list [email protected] http://lists.rousette.org.uk/mailman/listinfo/tracks-discuss
