Could you use <context, project>? Then it would be the same as completed
actions which use that order too.

 

2) that bug is in master too. Could you file a bug? It's probably the js on
the todo that is not restored.

 

Reinier

 

Van: Henrik Bohre [mailto:[email protected]] 
Verzonden: woensdag 19 augustus 2009 22:47
Aan: Reinier Balt
CC: tracks-discuss
Onderwerp: Re: [Tracks-discuss] Re: Action dependencies merge candidate

 

http://tracks-deps.heroku.com now features an implementation of predecessor
selection with description <project, context>.

It's not very well tested but should give you a feel for a possible way to
distinguish between todos with the same name but different project or
context.

Known bugs: 
1. For some reason it does not work with "." in the descriptions. Remember
seeing a ticket with a similar problem?
2. After editing/updating a todo: Editing and cancelling a todo makes the
menu impossible to open again. This behavior predates the latest commits.
Not sure when it was introducted.

Opinions?

/Henrik

On Wed, Aug 19, 2009 at 1:24 PM, Henrik Bohre <[email protected]>
wrote:

1. I agree that we can skip the creation date.
2. I agree that it would be nice to encode the id into each item, but we
still need to display the other information don' t we? I'm not sure that
displaying project and context is that confusing. Are you thinking about
minimizing the DB accesses? Otherwise it would be ok to search for the todo
with the supplied info.

/Henrik

 

On Wed, Aug 19, 2009 at 12:12 PM, Reinier Balt <[email protected]> wrote:

1) And 3) I think we should forget about the creation date. We never show it
in the gui anyway, so even if you show it, it would be difficult for a user
to use it.

 

2) true, but showing all that info in the textbox in the form would be very
confusing. I think we need to investigate passing around id's of the todos
without showing them. See for example
http://wiki.github.com/madrobby/scriptaculous/ajax-autocompleter at the
bottom where afterUpdateElement is used to get the id of a selected item.
Since we allow more todos in the field, you need to maintain some sort of
list with the id's of the selected todos

 

Reinier

 

Van: Henrik Bohre [mailto:[email protected]] 
Verzonden: woensdag 19 augustus 2009 11:42


Aan: Reinier Balt
CC: tracks-discuss
Onderwerp: Re: [Tracks-discuss] Re: Action dependencies merge candidate

 

1. One could argue that there seldom is necessary to have more than one
uncompleted todo with the same description, project and context. If so we
can skip the creation date which makes the line shorter. It is however
possible to have info on more than one line.
2. If description together with project and context is unique we should be
able to retrieve the correct todo.
3. OTOH. Currently it is not difficult to create many todos with the same
description, project and context, and thus make it impossible to distinguish
without creation date.

/Henrik

On Wed, Aug 19, 2009 at 11:02 AM, Reinier Balt <[email protected]> wrote:

Hm, you're right. There are actually two problems:

1.    Selecting the right todo from user perspective. How to distinguish
them if they have the same name

2.    Passing tracks the right id for todos that have the same name. If the
user picks the second name, Tracks will currently just pick the first it
finds

 

I'm not sure how big problem 1) is. How do people distinguish them now?
Either by tags or project or context. 

If you want to put all that info in the autocomplete, it would be a very
wide field. Perhaps autocomplete is able to place the info on 2 lines? 

 

2) is necessary. Even if you fix 1) you get into trouble with 2) :-)

 

Reinier

 

Van: Henrik Bohre [mailto:[email protected]] 
Verzonden: dinsdag 18 augustus 2009 17:01
Aan: Reinier Balt
CC: tracks-discuss
Onderwerp: Re: [Tracks-discuss] Re: Action dependencies merge candidate

 

I maybe I understand what you mean, but there still has to be some way for
the user to distinguish between actions that may only differ from the
creation time.

/Henrik

On Tue, Aug 18, 2009 at 11:56 AM, Reinier Balt <[email protected]> wrote:

I never really investigated the autocomplete. But isn't there some option to
use it like a selectbox where you see the name of the todo, but the browser
sends the id of the todo?

 

Reinier

 

Van: [email protected]
[mailto:[email protected]] Namens Henrik Bohre
Verzonden: maandag 17 augustus 2009 19:09
Aan: tracks-discuss


Onderwerp: [Tracks-discuss] Re: Action dependencies merge candidate

 

1-4: "Only work" I guess.
5: Hm, forgot about this one. I haven't really thought this through but what
about displaying the project, context and creation date also? Not sure if we
should display that info always or only when needed to disambiguate.

Example autocomplete list where we've started typing "buy"

buy
Buy shoes
Buy bread <Breakfast, Supermarket, 2009-01-01 07:00>
Buy bread <Dinner, Supermarket, 2009-01-01 07:10>
Buy bread <none, Bakery, 2009-01-01 13:00>

/Henrik

On Mon, Aug 17, 2009 at 3:09 PM, Reinier Balt <[email protected]> wrote:

I'd like to merge it into trunk/master if
1) you could rebase to current master
2) create a clean patch. You have added some 'noise' to your tree that I
prefer not to add to master, like you changes to the default databases or
the changes to .gitignore. I'd suggest you create a new tree from master and
cherry-pick the right patches. I could pull from there.
3) make sure things work for home view, context view and tag view, besides
project view.
4) I'd like to see some tests for the new functionality, but we could add it
in master too
5) you link a todo to its predecessor by looking for the description of the
predecessor. This won't work if you have more than one todo with the same
description which we cannot rule out (I've got several todos with the same
name in different contexts currently). We need to find a solution to this.
See
http://github.com/bohrax/tracks/blob/5967a0433b9211916f8291e77d32071e87eac4d
<http://github.com/bohrax/tracks/blob/5967a0433b9211916f8291e77d32071e87eac4
d%0A5/app/models/todo.rb#L96> 
5/app/models/todo.rb#L96 and
http://github.com/bohrax/tracks/blob/5967a0433b9211916f8291e77d32071e87eac4d
<http://github.com/bohrax/tracks/blob/5967a0433b9211916f8291e77d32071e87eac4
d%0A5/app/models/todo.rb#L114> 
5/app/models/todo.rb#L114

I hope to find some time to help out with 3) and 5)

Reinier

> -----Oorspronkelijk bericht-----
> Van: [email protected] [mailto:tracks-
> [email protected]] Namens Luis Villa
> Verzonden: maandag 17 augustus 2009 13:23
> Aan: Henrik Bohre
> CC: tracks-discuss
> Onderwerp: [Tracks-discuss] Re: Action dependencies merge candidate

>
> On Sun, Aug 16, 2009 at 5:35 PM, Henrik
> Bohre<[email protected]> wrote:
> > Hi all,
> >
> > most readers on this list is probably aware of the dependencies
> branch I
> > started a while ago.
> >
> > The latest features include:
> > * Add dependencies with drag and drop
> > * Hierarchical view of successors
> > * Remove dependency with single click (Thanks Reinier!)
> > * Improved ajax updates
> >
> > Just wanted to let you know that I think it's starting to reach a
> maturity
> > level where it's reasonable to think of merging it into the 1.8
> branch.
>
> I have not tried the changes of the past 24 hours, nor have I looked
> at the code, but from this user's perspective it is definitely
> maturing and probably ready for inclusion in trunk.
>
> Luis

> _______________________________________________
> Tracks-discuss mailing list
> [email protected]
> http://lists.rousette.org.uk/mailman/listinfo/tracks-discuss

 

 

 

 

 

_______________________________________________
Tracks-discuss mailing list
[email protected]
http://lists.rousette.org.uk/mailman/listinfo/tracks-discuss

Reply via email to