Kevin Ryde <[email protected]> writes: > Doing a bit of a grep I noticed the defadvice tramp puts on > file-expand-wildcards may use the value from ad-do-it. > > I believe that value can't be relied on, that it should look at > ad-return-value since ad-do-it is only whatever the next innermost > advice evaluates to, which can be anything.
Thanks, I'll check it. > Perhaps along the lines below, except untested as I'm not smart enough > to reach the affected code. Hmm, this is very old code. I'll check first, whether this is still needed. > Incidentally, the ad-unadvise in tramp-unload-hook probably should > confine itself to the particular piece of advice added, so as not to > affect anyone else's advices on file-expand-wildcards (in the unlikely > event there are any others!). That's true as well. Something like ad-remove-advice would be more precise. Best regards, Michael. PS: Could you, please, prepare a Changelog entry? _______________________________________________ Tramp-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/tramp-devel
