Nicolas François wrote: > Hi, <snip>
> I'm attaching the patches which I think could be worth being applied at > this time: > * pootle_typos.patch > * pootle_gnuprojects_no_detect.patch > * pootle_logos_prefs.patch > * pootle_mail_header.patch Thanks a lot for your contributions, I've committed them. With pootle_logos_prefs.patch I changed the except statements to specifically catch AttributeError instead of any exception. I hope there aren't any other types of exceptions that can be raised by that getattr snippet. pootle_gnuprojects_no_detect.patch also has a catch-all except. Do you know of a specific exception that would be triggered in that block of code? I've committed the except clause as is now because any exception in there would just allow the current/previous code to be run as fallback. But we should consider specifying an explicit exception there. Friedel suggested that the autodetect code in hasgnufiles() should save the treestyle after detection. The method would then be slow only the first time it's run. And then we can decide whether it's really necessary for the treestyle to be specified in the web interface. > > I can provide some measurements for the speedups of > pootle_gnuprojects_no_detect.patch and pootle_no_autoload.patch if you > wish. That would be interesting to see :-) Regards, Andreas -- http://translate.org.za/ ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Translate-pootle mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/translate-pootle
