On Do, 2007-06-14 at 05:55 +0200, lars wrote: > Hi, > > I submitted a patch proposal quite a long time ago > (12th of January 02007 - > http://sourceforge.net/mailarchive/forum.php?thread_name=20070112043558.080c53b3%40erker.wg&forum_name=translate-pootle) > regarding the version control support of pootle. > At that time the patch caused problems as it required another python module > (pysvn). > Finally (sorry for the delay), I took the time to remove this dependency. > The only intermediate change of trunk's versioncontrol.py was the > implementation > of darcs support. I integrated this, too. > > The attached patch does the following: > 1) allow to _symlink_ version controlled files (thus it is possible for > projects to use a completely arbitrary directory layout without loosing > pootle's > version control feature) - read the previous thread for more details > 2) use objects instead of plain functions for the handling of different > version > control systems - this should ease the work of adding more version control > support (and it simplifies the code) > > The patch successfully works regarding updates/commits with subversion. More > tests for CVS and darcs should be necessary. > > Do you think, that the patch goes into the right direction? > > There is still some stuff missing, like: > - avoid to use the shell for executing commands (by using arrays instead of > strings for popen2) > - replace shell commands with python functions (e.g. "mv") > - replace unix-only pieces (e.g.: replace "/" with os.path.sep) > - cleaning up the version control interface > These things should get fixed afterwards. > > regards, > Lars
I just started looking at the patch now. I think I will probably commit it quite soon, but here are just a few comments: * There are no users of the functions hascvs, hassvn, and hasdarcs - can we drop them? * After moving to the toolkit, would it be meaningful to split this into separate files? Perhaps even a dedicated directory under storage/versioncontrol? * I will make some cosmetic changes, but I see things like the error messages were not consistent before the change, so nothing against you, Lars :-) F ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Translate-pootle mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/translate-pootle
