Am 09.07.2012, 16:47 Uhr, schrieb Jan Kundrát <[email protected]>:
- Please use "0" instead of "NULL" (see [1], even though it isn't terribly explicit in there).
No problem. I used to prefer 0 (or rather 0L) anyway, but andFYI the /current/ talk around KDE is to use NULL because it can easily be sed'ed into nullptr later on - what has a valid point to it.
It's possible to use the colors (and even the general look) the style uses for headers (the default color role is Base, it's an abstractitemview)- The header of the message view has black background on my style (Oxygen) -- that's a no-go from my point of view.
That's because the viewer is (usually) a groupbox which uses a "Preferred" size policy but the tag were not set fixed. The better approach to this is to set the viewer to "Expanding" (just as the QWebView)- The spacing in the headers of the message view is still "wrong", ie.
Done. You gained access to somebody who's probably read all QWidget sources ;-)state, but if you're touching this part, I'd prefer to have this one fixed, too, preferably in a separate patch.
- I don't like the lazy creating of the QTimer
Ok
Braces, ie "(or from jan to jan) since 1-July-2012" will currently not work. The reason is (is?) that ::requestingSearch() expects a stringlist of keys or parameters - and braces are neither. I've not looked at the backend so far, but would have expected it'd just pass a string to the server (and then ran into having perform quoted whitespace splits ;-)I also managed to introduce a very embarrassing bug with OR in that code, so I don't really see people using that too much) -- it's an excellent idea for now.
"advanced users", why not simply return a single-element QStringList() << foo.text()?
Tried, failed. Don't know why. "BAD Could not parse command" And no, i don't like the parser either. See above.
Oxygen is "special" here, but i can override it's assumptions (as long as Hugo doesn't want to start a race on this =)- Not sure if the "flat" presentation of the message parts is better -- I see that the old look is probably pretty cluttered up, but the new one looks weird on my style -- see the attached screenshot.
No. This kind of search is very limiting compared to IMAP capabilities (first time I logged in with the generic ssl client was some kind of epiphany regarding what -most- mail clients so far hided from users) The major defect is that you must know the query keys and also the "strange" polish (prefix operators) syntax.- Do you really like the buttons-right-from-the-qlineedit?
Therefore i'd suggest a syntax clicker, ie. a popup (behind a toolbutton with a nifty icon, takes little space) to assist the user in generating valid IMAP queries. Basically you select "From:" and the lineedit is completed by "FROM <string>" and "<string>" is selected (so you overide it by typing), OR and AND are provided as "Match any" and "Match all" subgroups injecting "(OR <search>)", "<search>" being selected and replaced as soon as you click (eg.) "From" from the popup.
Before we pass the string, we'd just do a quick check whether it looks like a valid query at all and otherwise perform a default simple search in Subject & Sender.
-> Thoughts?
I was afraid of large rewrites and stuff about 10 years ago (really, i sometimes thought "that's never gonna compile again ever" ;-) but no longer.Well, the multiaccount support is going to be a rather big change -- doable, but intrusive into many parts of Trojitá.
I'll just try.
I'm very close to the deadline of my thesis
TAKE YOUR TIME! I can easily have /others/ to wait for stuff as long as a) i can have it now b) i know i didn't (entirely) write it for the dumpster Cheers, ThomasPS: would you mind removing the sort action popup and instead make the header sorting (as much as possible, ie. if there's no sort extension on the server you can just swap order by clicking anywhere) Afaik there's either sorting or not (not "sort by date and subject but nothing else) so one could in absence of the sort extension even present the header as a unique section (with several items)
0001-pimp-message-view-better.patch
Description: Binary data
0001-re-layout-searchbar-align-views-autoreset-search.patch
Description: Binary data
