On 10/10/12 01:04, Thomas Lübking wrote:
From 080a29d507e8e34a399ac1b097f3baa36229363d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20L=C3=BCbking?=<[email protected]>
Date: Tue, 9 Oct 2012 20:08:34 +0200
Subject: [PATCH 1/4] move attachment section into top right corner
After applying this patch, clang refuses to compile Trojita anymore:
./ui_ComposeWidget.h:113:19: error: no member named 'setBuddy' in
'QGroupBox'
groupBox->setBuddy("subject");
~~~~~~~~ ^
Fixed manually, the patch is in.
+ foreach (const QUrl &url, urls) {
Trojita uses Q_FOREACH, please try to stick with that in future.
+ setMouseTracking( true );
Please don't add spacing here.
About patch#2 in general -- I remember hitting some asserts when I tried
to add d&d support originally. Indeed, they're still in there.
Just open the composer, add a file attachment and click & drag it below,
so that it is about to be added once more. Upon mouse release, I hit
this assert:
ASSERT: "stream.atEnd()" in file
../../../../trojita/src/Imap/Model/MessageComposer.cpp, line 108
This patch is *not* in.
The rest of the patches in the series depend on #2, so they're not in,
either.
Cheers,
Jan
--
Trojita, a fast e-mail client -- http://trojita.flaska.net/
