On 10/13/12 03:08, Thomas Lübking wrote:
I didn't touch it, but "no" - diretcly aborting worked.
Please build Trojita with `qmake CONFIG+=debug`. The asserts are pretty
common in the code and the release builds skip them over.
However in
the current HEAD i don't get any debug out failure when dragging an
attached file into the attachment (while actually not entirely sure
what this is supposed to be good for ;-)
It's useless on its own, but important for support for reordering of
attachments my mouse drags (which is missing for now). It's also a great
test case for corner cases in the code, as shown here.
1. pending file DND attachement support
Well, this patch makes the composer *input box* accept drag-and-drop of
"a list of files". This makes it accept a limited subset of what the
attachment widget handles -- just try dragging a message or a message
part from inside Trojita to the composer. That's inconsistent; if a drop
is supported on the text input widget, it *must* be also supported in
the attachment widget. I actually don't care about being able to drag
something to the text widget, but I also don't oppose such feature --
but I strongly object to the text widget accepting only "something".
It's in, but please make it accept the other MIME types as well.
2. the ctrl+enter patch
(leave it if you fear it, but you'll not be able to trigger mentioned
behavior when waiting a couple of ms between releasing ctrl and
pressing enter)
Applied.
3. input constrainments
Applied.
4. automatic search reset on emptying the serachline
Applied.
5. new take on the search GUI - even the
present button solution is some sort of squeezed in my netbook ->
stashed stuff behind a popup toolbutton, including a raw IMAP query
builder.
Having the button on the left is weird for me -- if I type a search
query in, my eyes move to the right and I expect the button to be there,
not on the left. I've moved it to the right where it belongs, IMHO.
Please speak up if you dislike that.
I'm not sure it's a great idea to hide the quick search options below a
button. I'll give it a few days to see if I like it on my system with
big enough screen.
The patch is in.
On the IMAP queries: i tried that on some users and the major issue
is that the polish notation is completely incompatible with regular
humans (aka "dummies" ;-)
The builder adds some placeholders and (partially) autoselects them
and that worked pretty good for the simple things (subject, since
etc.) and even the negation, but when i asked them to perform a
juncted query ("or") ... well, we all got a little upset =)
There's no error handling; if the query fails, the user is not alerted,
except in a qDebug output. That should be added as well.
Right now i've however no better idea on this :-(
I'd say that it's a great start.
Please also take care to review the patches I pushed in, I had to clean
up a few places.
Cheers,
Jan
--
Trojita, a fast e-mail client -- http://trojita.flaska.net/
