On Thursday, 21 February 2013 17:14:47 CEST, Thomas Lübking wrote:
You're kinda lucky because i rebased it on current master last night.
I can send around a plain patch for testing (due to personal
dumbness i'd have to perform a force push on the multiaccounts
branch - if you want all commits individually for a review)
which would however atm. still include two unrelated commits.
However, I've not tested the rebase so far (except for more or
less "at this very moment") - so there's no guarantee.
If you wanna review (on board?) again and are fine with it, we
could move the patch into master and then start out improving
things there (like re-adding the config gui) - what will be much
more convenient.
Doing big patches in branches still sucks, git or not =)
Hi Thomas, it looks to me that we both have more interesting work to do, so
it's too easy to just keep indefinitely postponing the multiaccounts work until
later.
However, my idealism has still not faded completely, and I'd like to try a
"proper" git workflow this time. This means that I'd like to merge it to master
only after it's working reasonably well and the proxy model at least is covered by a
couple of unit tests.
Based on my experience with how the proxies I wrote work and how many bugs they
contain at the beginning, I expect that there's a couple of unhandled corner
cases in your proxy as well. If I'm correct, this will involve a few rounds of
fixes and debugging, and this means a lot of commits, and I think that these
shall be rewritten to produce a neat history before the merge.
Could you please push the work you have now somewhere? I hope I'll be able to
look at the code tomorrow evening or during Saturday (possibly also some
initial look later today). I volunteer for writing the unit tests. For me, this
proxy is the place where I expect to find the majority of subtle bugs, so I'd
like to focus on it at first. I'm confident that the rest (be it the settings
dialog or the GUI integration) will be reasonably streaightforward without
nasty surprises.
Does it work for you?
With kind regards,
Jan
--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
