Hello Jan,

I am working on a project currenlty as a part of my academic works. And hence 
the delay in submitting the patch. Here is the link to the file :
https://github.com/sreepriyachalakkal/trojita


Whitespace issue.
I have cleared that.

- The ComposeWidget::slotCheckAddress() still sets a green background for valid addresses. I find that distracting. Wouldn't it be better if the background was QPalette::Base by default and changed to red when there was a non-empty but invalid e-mail address?

I dont know why you are getting a green background. I dont get that and it 
works fine for me. I had set white color instead of green.

- The git branch contains extra changes (the README file) and also unrelated commits. Some of the commits were made with an invalid e-mail address. I need a branch with just a single commit on top of current master branch (7a434c3).

I deleted that and created a new one. Hope this is fine.


--
--
Sreepriya C
Amrita School Of Engineering
www.priyachalakkal.wordpress.


Reply via email to