[trojita] Re: Color tinting and theme-awareness

[Sreepriya Chalakkal]

Hi,

Thanks. Any reason you haven't used the following?
if (edit->text().isEmpty() || parseRecipients(recipients, errorMessage)) {
    edit->setPalette(QPalette());
} else {
    QPalette p;
    p.setColor(QPalette::Base, 
Gui::Util::tintColor(p.color(QPalette::Base), QColor(0xff, 0, 0, 
0x20)));
    edit->setPalette(p);
}

I find this a bit cleaner -- it makes it clear that the 
coloring only happens when the mail is not parsed properly 
instead of separating the "empty string" and "valid mail" into 
unrelated branches. What do you think about this?

I agree that this itself is more clear compared to the other. I didnt think much regarding the unrelated branch. I just checked if it works fine. But this is more clear. I will make the change. 



--
Sreepriya C
India
www.priyachalakkal.wordpress.com