On Thursday 20 June 2013 20:42:34 Jan Kundrát wrote: > On Thursday, 20 June 2013 15:42:28 CEST, Pali Rohár wrote: > > virtual void requestComplete(const QString &input, const > > > > QStringList &ignores = QStringList(), int max = -1) = 0; > > Either "requestCompletion" or "requestCompleting", but to me, > "requestComplete" means something very different than > "request a completion", I read it as "a request has been > completed". >
Ok, I rename it to requestCompletion
> You can also kill the ignores parameter, it doesn't appear to
> be used. Thomas, do you have a comment on that, given that
> originally added this?
>
> > void completionAvailable(const QString &input, const
> > QStringList &list);
>
> I'd suggest this ("list" is not a terribly self-explaining
> name):
>
> void completionAvailable(const QString &input, const
> QQstringList &completion);
>
> I'm also slightly unsure about whether it should be changed to
> a QList<QPair<QString, QString> > to pass the human readable
> names and e-mail addresses separately. Opinions?
>
List of pairs sounds good.
> > class AddressbookFactoryInterface {
> >
> > virtual QString name() = 0;
> > virtual QString description() = 0;
> > virtual bool isValid() = 0;
>
> These should probably all be const. I also wonder about the
> usefullness of the isValid() -- if it's e.g. an LDAP address
> book, do you expect to test connection to the remote server
> during isValid()? If so, it should probably asynchronous, but
> that would only make it troublesome to use it...
>
> Cheers,
> Jan
With isValid() I mean if all required programs/libraries/other
dependences for plugin are installed. E.g. for some akonadi
plugin it will check if akonadi server is installed and can be
started (it is not disabled by user/admin)... Something which can
be immediately checked on startup.
--
Pali Rohár
[email protected]
signature.asc
Description: This is a digitally signed message part.
