On Friday, 2013-06-21, Pali Rohár wrote:
> I added virtual features() method and changed open contact window methods.
> Now there is method openContactWindow() for existing contact and method
> openAddContactWindow() for adding new contact. Trojita should check if
> contact is already addressbook by contactExist() and then decide if will
> show button for adding new contact or open existing. Also check if
> addressbook is readonly, so button for adding new contact will be
> disabled.

Hmm, how often does it check that, or is a plugin only ReadOnly if it can 
never ever write, e.g. addressbook file on a read-only optical drive?


>     /**
>      * @short Return true if contact exists in addressbook
>      **/
>     virtual bool contactExist(const QString &email) const = 0;

That looks like something that shouldn't be synchronous.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to