On Friday, 21 June 2013 22:36:48 CEST, Pali Rohár wrote:
virtual qint64 features() const = 0;
I am no expert on this part of the language, but wouldn't a quint64 make more
sense here? Presumably, one wants to use it like this:
if (plugin->features() & AddressbookInterface::ReadOnly) ...
Which leads to an interesting problem, unless I'm wrong -- what is the size of
the AddressbookInterface::ReadOnly, and does it really mask-out any bits but
the LSB one?
Do we really have to mess with C-style features here? Could we use something
reasonable like QFlags and Q_DECLARE_FLAGS? Does it provide what we need
(especially the constant size of the return value)?
Apart from that (and the style issues I raised in the review of the password
plugin interface, and a missing license header which shall be put there when
you commit your stuff into git), this looks good -- thanks!
Cheers,
Jan
--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
