Hi, sounds good and i am sure that you did a really good job with this. from my side you can push the patch directly.
Am Mittwoch, den 03.02.2010, 13:48 +0100 schrieb Cédric Krier: > Hi, > > I have almost finished the refactoring of the client: > > - Better naming for model parts: > - group instead of: models, model etc. > - record instead of: model etc. > - fields instead of: mfields, fields, field etc. > - Group will no more use an external list but it is now a list > - Group has an index on record id > - New common windows for dialog of many2one, one2many and many2many > - one2many and many2many dialog use the same screen than the widget which > means that the views are no more requested when opening the dialog box. > - Remove a lot of duplicated variables (on Screen from 21 to 13) > - Remove RPCProxy to handle logout exception on every request > - Cleaning of internal signal: better naming > - Fix on_change detection for many2many [1] > > > There is 2517 lines added and 2822 removed. > I don't know if it will be useful to upload patch to codereview. Is there > anybody that will review it? > > There is still some stuff that will need refactoring like the WidgetParser but > it will be for an other patch as this one becomes very big but was necessary. > Others will be smaller. > > When the patch will be pushed, I think it will be good that everyone test the > client to be sure there is no lost of functionnality. > > Thanks. > > [1] http://bugs.tryton.org/roundup/issue1400 > -- Korbinian Preisler ____________________________________ virtual things Preisler & Spallek GbR Munich - Aix-la-Chapelle Windeckstr. 77 81375 Munich - Germany Tel: +49 (89) 710 481 55 Fax: +49 (89) 710 481 56 [email protected] http://www.virtual-things.biz -- [email protected] mailing list
