Hi, Am Mittwoch, den 03.02.2010, 13:48 +0100 schrieb Cédric Krier: > I have almost finished the refactoring of the client: > - Better naming for model parts: > - group instead of: models, model etc. > - record instead of: model etc. What is now the difference or better the definition for group and record?
> - fields instead of: mfields, fields, field etc. Good. > - Group will no more use an external list but it is now a list I don't understand. > - Group has an index on record id > - New common windows for dialog of many2one, one2many and many2many > - one2many and many2many dialog use the same screen than the widget which > means that the views are no more requested when opening the dialog box. This sounds good. > - Remove a lot of duplicated variables (on Screen from 21 to 13) yes! > - Remove RPCProxy to handle logout exception on every request > - Cleaning of internal signal: better naming > - Fix on_change detection for many2many [1] ok. > There is 2517 lines added and 2822 removed. > I don't know if it will be useful to upload patch to codereview. Is there > anybody that will review it? No way for me. It is good to have it on codereview anyway, but for me you can push the code to trunk to test. > There is still some stuff that will need refactoring like the WidgetParser but > it will be for an other patch as this one becomes very big but was necessary. > Others will be smaller. yes thats good. > When the patch will be pushed, I think it will be good that everyone test the > client to be sure there is no lost of functionnality. Yes of course, I'll test. Thanks for the major cleanup! Regards Udo -- [email protected] mailing list
