On 16/12/11 09:37 +0100, Albert Cervera i Areny wrote: > We need to implement lot management in Tryton and I've created a blueprint > for > that [1]. Hope we can collect your comments there and in the mailing list. > > Thanks! > > [1] http://code.google.com/p/tryton/wiki/LotManagement
Here is my review: - "Add 'stock.lot' model with just the "Number" field as fields.Char()" I think better name is product.lot in his own module because you can want to use it without stock management. It requires a link to product.product and move could only use lot of the same product. - "Adapt assign_try() and pick_product() to take 'lot' field into account." I'm not sure this is good. For me, lot is more like a tag on moves and it should not prevent to validate the move. Also I think such behavior will be very resource consuming. - "Add a new products_by_location_and_lot() function, similar to products_by_location() that will use (product, location, lot) as key and will return the quantities." product and lot are duplicate informations if there is a link between lot and product. But I'm not sure it will be useful. I think it will be better to have a view that shows all the move of a lot (perhaps a Tree). - "Add 'lot' field to all shipment views." It will be done on stock.move once nested views are removed. -- Cédric Krier B2CK SPRL Rue de Rotterdam, 4 4000 Liège Belgium Tel: +32 472 54 46 59 Email/Jabber: [email protected] Website: http://www.b2ck.com/
pgpa6k7FssaBr.pgp
Description: PGP signature
