A Dimecres, 25 de gener de 2012 13:45:25, Cédric Krier va escriure: > On 16/12/11 09:37 +0100, Albert Cervera i Areny wrote: > > We need to implement lot management in Tryton and I've created a > > blueprint for that [1]. Hope we can collect your comments there and in > > the mailing list. > > > > Thanks! > > > > [1] http://code.google.com/p/tryton/wiki/LotManagement > > Here is my review: > > - "Add 'stock.lot' model with just the "Number" field as fields.Char()" > > I think better name is product.lot in his own module because you can > want to use it without stock management. > It requires a link to product.product and move could only use lot of > the same product.
Can't think of a use-case myself, but I see no problems with it. The less dependencies the better. > - "Adapt assign_try() and pick_product() to take 'lot' field into > account." > > I'm not sure this is good. For me, lot is more like a tag on moves and > it should not prevent to validate the move. > Also I think such behavior will be very resource consuming. I think it should. Of course, we can discuss on what's the best default behaviour of stock_lot module, but I'm sure that many companies will need to be sure that the current stock levels are ok and that includes the exact lots available. If you cannot rely on that, it has no sense to manage lots (at least, in many use cases). > - "Add a new products_by_location_and_lot() function, similar to > products_by_location() that will use (product, location, lot) as key > and will return the quantities." > > product and lot are duplicate informations if there is a link between > lot and product. > But I'm not sure it will be useful. I think it will be better to have > a view that shows all the move of a lot (perhaps a Tree). It's true that it is duplicate, it would probably be enough with location and lot. > - "Add 'lot' field to all shipment views." > > It will be done on stock.move once nested views are removed. Yes, that's a great improvement ;-) -- Albert Cervera i Areny http://www.NaN-tic.com Tel: +34 93 553 18 03 http://twitter.com/albertnan http://www.nan-tic.com/blog -- [email protected] mailing list
