A Dissabte, 28 d'abril de 2012 16:41:35, Cédric Krier va escriure:
> On 25/04/12 13:46 +0200, Cédric Krier wrote:
> > On 25/04/12 11:37 +0000, [email protected] wrote:
> > > Please review this at http://codereview.tryton.org/346003/
> > 
> > This is a first draft for our next step to the Active Record pattern.
> > Let's talk here about the design.
> > Here are the main changes:
> > 
> > * Add RPC
> > * Repace BrowseRecord by Model instance
> > * Replace Cache decorator by a simple LRU Cache
> > * Remove Cacheable
> > * Remove _description
> > * Rename _name by __name__
> > * Use class in Pool

I love this one. Bye, bye *_obj!

I think you missed:

* Return objects instead of id's in create, search, etc.

> 
> Really ! Still no comments?
> 
> Guys, I need to know your thoughts and ideas to improve it before
> starting patches for modules.

Well, the patch is huuuge :)

Just started to review it. Hope to be able to give feedback tomorrow.

BTW, did you make any performance comparison? For example, to see if returning 
objects in search() or create() affect performance noticeably.

-- 
Albert Cervera i Areny
http://www.NaN-tic.com
Tel: +34 93 553 18 03

http://twitter.com/albertnan 
http://www.nan-tic.com/blog

-- 
[email protected] mailing list

Reply via email to