A Dijous, 11 d'octubre de 2012 14:33:00, Raimon Esteve va escriure: > 2011/12/4 Albert Cervera i Areny <[email protected]>: > > * account_payment_type: Depends on account_invoice and adds the module > > account.payment.type which just has a translatable field "name". It also > > adds two properties to parties: customer_payment_type and > > supplier_payment_type. payment_type field is also added to > > account.invoice and account.move.line. > > https://bitbucket.org/zikzakmedia/trytond-account_payment_type
I think account.payment.type should have no "code" field. If you think there should be one, search function for rec_name should be changed to take it into account, and in any case it should not be required. Do you think notes are needed? If so, do they really need to be translatable? > > * sale_payment_type: Adds a payment_type field to sale orders. The value > > is moved to invoices. > > https://bitbucket.org/zikzakmedia/trytond-sale_payment_type _get_invoice_sale() is not consistent with the behaviour of account_payment_type module. Note that sale orders may create credit notes and payment_type should be the one of the company instead of the one of the partner. Why do you define a default value for payment_type which will only be filled in when there's only one payment type. I don't think it makes much sense specially because the field is not required. > > * purchase_payment_type: Adds a payment_type field to purchase orders. > > The value is moved to invoices. > > https://bitbucket.org/zikzakmedia/trytond-purchase_payment_type Same problem as sale_payment_type. Also, there's a copy & paste issue with sale module because you use "customer_payment_type" instead of "supplier_payment_type". I think it would be nice that those modules were code reviewed in codereview.tryton.org. I think it could be added to core if other countries have similar needs. > > * account_payment_order: Implements account.payment.order, to be > > discussed in another e-mail. > > Pending from Nan-tic PS: There are several .pyc files in the repository. -- Albert Cervera i Areny http://www.NaN-tic.com Tel: +34 93 553 18 03 http://twitter.com/albertnan http://www.nan-tic.com/blog -- [email protected] mailing list
