Hi, I have made a quick review of nereid in foresight of his inclusion. So here are some comments:
* Split into two packages:
- nereid: the flask application
- trytond_nereid: the Tryton module
* Versioning: we should switch to the same versioning schema of Tryton
* Upgrade to trunk (Active Record)
* Use similar COPYRIGHT method
* MemcachedSessionStore should be rename as it is multi-backend support
* render_email should be moved to trytond base
* the jinja2 cache should be configurable instead of forcing Memcache
* I would drop TrytonTemplateLoader to use only FileSystemLoader
* I would drop crontrib.gravatar because not really required and could be
provided by external lib
* also contrib.sphinxsearch
* and contrib.testing.xmlrunner
* Not sure ir.attachment.uploaded_by is really needed
* There is a misunderstanding about Address because it is used as a
user, it should be move to party.
* The dependency to ccy could be dropped or at least move into a
separate module
* Test framework should be adapted to trytond one.
Remarques:
- I'm not sure to understand: nereid/caching.py
- I'm wondering of Form could not be generated automaticaly.
--
Cédric Krier
B2CK SPRL
Rue de Rotterdam, 4
4000 Liège
Belgium
Tel: +32 472 54 46 59
Email/Jabber: [email protected]
Website: http://www.b2ck.com/
pgptAmnjXw1gk.pgp
Description: PGP signature
