On 17/11/12 08:44 +0530, Sharoon Thomas wrote: > On Nov 17, 2012, at 5:56 AM, Cédric Krier <[email protected]> wrote: > > > > * render_email should be moved to trytond base > > render_email depends on the template loader and the render_template method > which depends on nereid/flask
We should have a generic Tryton way to render emails.
Because once we drop the res.request, we will have to send email in the
core system.
> >
> > * Not sure ir.attachment.uploaded_by is really needed
>
> There is no way to know the nereid user who uploaded the document without
> this field
Yes but it could be done by an external module.
> >
> > * There is a misunderstanding about Address because it is used as a
> > user, it should be move to party.
>
> This has been resolved in recent version with nereid.user object. It is the
> doc string which has a bug. And nereid.user _inherits from party.party
So I propose to drop the legacy code.
> >
> > * The dependency to ccy could be dropped or at least move into a
> > separate module
>
> I am in for dropping this. I am not fond of the library either and its
> poorly maintained. What is your recommendation for linking
> currency with locale ? (in a separate module of course)
Yes it could be done with a module for those who needs the
functionality.
> >
> > * Test framework should be adapted to trytond one.
>
> It uses unittest2 (or unittest in python 2.7). Do you want this
> dependency to be dropped ?
I want that the test will be launch when running:
trytond/tests/tryton_test.py --modules
> > Remarques:
> >
> > - I'm not sure to understand: nereid/caching.py
>
> The Cache class is a wrapper over the current_app's cache instance.
> This wrapper pattern allows the method 'cache' of the class to be used
> as a decorator (like memoize) even before there is a cache instance.
Could you show a code using it?
Do you think we can replace by the trytond/cache.py ?
> > - I'm wondering of Form could not be generated automaticaly.
>
> I am working on this, but I have not made much progress so far.
Ok, this is not a priority any way.
--
Cédric Krier
B2CK SPRL
Rue de Rotterdam, 4
4000 Liège
Belgium
Tel: +32 472 54 46 59
Email/Jabber: [email protected]
Website: http://www.b2ck.com/
pgp5tSCAzA8sn.pgp
Description: PGP signature
