On 11/11/13 09:23 -0000, Code Review - New issues: guillemBarba wrote: > It replaces the simple 'select/option' HTML field by a combobox using > a third party JQuery UI plugin (based on demo-version combobox in JQuery UI > Documentation webpage).
I think we should not depend on a library that is not correctly maintained: no release, no package etc. > It has some issues: > - the widget doesn't expand to all the container width > - the required background is in the container, not in the widget (and with > the previous issue it looks wrong) [1] > - the on_change/on_change_with feature doesn't work That's quite a big problem. > Provably, its interesting to do our own version of Combobox widget (based on > that plugin) like is done by DateTime widget. And as its done in the plugin, > generalize the autocompletion feature to be used in other widgets. Yes why not. (I personaly don't find using the default browser selection an urgent issue.) > [1] as we talked, it would be great to move the "required" style > definition from JS to CSS. > It should be done removing the background (color) definition done in JS > (set_color()) by a class definition (something like 'required' or > 'sao-required') to the widget container, and the CSS sets the > background color to the correct tag (it can change for each widget, what now > is done by _get_color_el()). > It is more flexible (for example, it allow to fix the problem in combobox > widget) and allows to change the 'required' background color in > Themes. +1 -- Cédric Krier - B2CK SPRL Email/Jabber: [email protected] Tel: +32 472 54 46 59 Website: http://www.b2ck.com/
pgpHgZvoxIP24.pgp
Description: PGP signature
