On 19 Nov 14:59, Mathias Behrle wrote: > * Cédric Krier: " Re: [tryton-dev] Faster contribution" (Wed, 19 Nov 2014 > 12:44:15 +0100): > > > On 19 Nov 12:12, Mathias Behrle wrote: > > > * Cédric Krier: " Re: [tryton-dev] Faster contribution" (Wed, 19 Nov 2014 > > > 11:27:25 +0100): > > > - It should still be possible to track issues and reviews in the commit > > > message. > > > > review is appended to the patch. > > issue depends if the submitter add it or not. > > So this is dropped as a requirement?
It will depend of the issue. If the contributor will only provide a patch for an issue core developers find it needs one, it will be requested as comment. > > > - It should be possible to use a specified name and email address for the > > > commit message. > > > > Such contributor will have to use their preferred email address to login > > in rietveld. And they will have to set their real name. > > I doubt that will work. Not everyone wants to register every address (and > especially addresses for this usage) at Google. That's another topic. The move from appspot to self hosting is there since more than 3 years and nobody ever takes any steps, so we can guess it is not really an issue. https://bugs.tryton.org/issue2177 > > > Additional open questions for me with the proposed setup: > > > > > > - Until now I am missing the procedure, how the review gets into trunk. > > > > One core dev has to take it. > > That doesn't explain, how the procedure should work. A core dev will take a patch and push it. As contributor you don't have to care of any of this. > > > - It should at least exist an additional field for the mail address. Since > > > we are (still) tied to google for authentication, you don't want > > > necessarily > > > take the google registered address for the commit message. > > > > Use a google account for your preferred email address. I think it is the > > best way to do it as this will ensure we will have a valid address. > > I think this could be another quite substantial barrier for contribution at > all. Too bad for them. At some point, we must realize that people who are nitpicking to contribute, are losing but not the project. If you can fix an issue and you don't do it, it is bad for you not for us. > I found another point to add: > > - It should be able to work on a tree of repos (this being a feature of the > current setup and not being possible on github AFAIK). Such cases are for big changes (so out of cusual contributor) and we already have a good workflow for that for the core developers. -- Cédric Krier - B2CK SPRL Email/Jabber: [email protected] Tel: +32 472 54 46 59 Website: http://www.b2ck.com/
pgpgKWrfOYKal.pgp
Description: PGP signature
