On Monday, December 8, 2014 9:25:03 PM UTC+1, Cédric Krier wrote: > > On 08 Dec 09:42, Simon Klemenc wrote: > > sorry for putting this up top again, but from trying to contribute small > > pieces and looking at other codereviews a thing that remains unclear to > me > > from howto contribute is pep8. > > how should this be handled? When doing modifications on a file with pep8 > > issues, should those issues be fixed with the patch? > > No, you always provide unitary changesets. > > > or with a seperate patchset? > > Only if you fix them all. >
> > or should they be remained for the future? > > That's the easy option. > > > (making the reviewbot sort of pointless and more annoying than anything > > else) > > Not at all but the bot from time to time becomes more strict. > > so just in case it becomes even more strict and there is no 8771002, (please?) could you update the wiki, as its not obvious for the dumb but helpful folks... maybe in the coding guidelines it could also be noted that %s is the desired string-format format... http://codereview.tryton.org/12491002/ (why not: "please dont fix flake8 from others, they are fixed with 8771002") I really dont want to be bashing but after reading 14761002 i just fail to see the point of doing open source without accepting different opinions + i feel a little ashamed... sincerely, simon > -- > Cédric Krier - B2CK SPRL > Email/Jabber: [email protected] <javascript:> > Tel: +32 472 54 46 59 > Website: http://www.b2ck.com/ >
