I could really do without the additional indirection added by the separate XML files for each standard Valve implementation. They're just single XML elements, and do not need their own files. The amount of duplication introduced by inlining the elements is inconsequential, as they only consist of one piece of data--the class name--from which all other information can be divined.
Other than that, I love it. Thanks for doing the tests, Jason. Dan [EMAIL PROTECTED] writes: > jvanzyl 01/12/31 07:30:19 > > Added: src/test/org/apache/turbine/pipeline TestPipelineMapper.java > classic-turbine-pipeline.xml > default-action-valve.xml default-target-valve.xml > Log: > - Added a test for the mapping of a pipeline XML description to a pipeline > object using the mapper in stratum. > > 1.1 >jakarta-turbine-3/src/test/org/apache/turbine/pipeline/classic-turbine-pipeline.xml > > Index: classic-turbine-pipeline.xml > =================================================================== > <pipeline> > <name>ClassicTurbinePipeline</name> > <valveDefinitions> > <valveDefinition id="default-action-valve"/> > <valveDefinition id="default-target-valve"/> > </valveDefinitions> > </pipeline> > > > > 1.1 >jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-action-valve.xml > > Index: default-action-valve.xml > =================================================================== > <valveDefinition> > <name>DefaultActionValve</name> > <className>org.apache.turbine.pipeline.DefaultActionValve</className> > </valveDefinition> > > > > 1.1 >jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-target-valve.xml > > Index: default-target-valve.xml > =================================================================== > <valveDefinition> > <name>DefaultTargetValve</name> > <className>org.apache.turbine.pipeline.DefaultTargetValve</className> > </valveDefinition> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
