On 12/31/01 5:55 PM, "Daniel Rall" <[EMAIL PROTECTED]> wrote:
> I could really do without the additional indirection added by the > separate XML files for each standard Valve implementation. They're > just single XML elements, and do not need their own files. The amount > of duplication introduced by inlining the elements is inconsequential, > as they only consist of one piece of data--the class name--from which > all other information can be divined. You can specify them anyway you like all in one pipeline definition or by inclusion. Works both ways. I just figured that if we started getting comprehensive descriptions for the valves (for documentation generating purposes) or if we add anything else then we could keep all that info in a separate file. Plus if many pipelines start reusing different valves, which I hope to be the case eventually, I was thinking that the separate XML files would actually make it easier to reuse. > Other than that, I love it. Thanks for doing the tests, Jason. No problem, we should probably discuss how we want things to work then we can divvy stuff up as I imagine it will only be the two of us for the next little while, though I encourage anyone else to play. I actually want to try and get the resources package into stratum so that we can start pulling config info from the filesystem or the classpath (or a datasource, url, or whatever) I taken pieces from the the resource management system originally used in velocity and tried to clean it up a bit. But I guess we can talk about that next year! :-) > Dan > > > [EMAIL PROTECTED] writes: > >> jvanzyl 01/12/31 07:30:19 >> >> Added: src/test/org/apache/turbine/pipeline TestPipelineMapper.java >> classic-turbine-pipeline.xml >> default-action-valve.xml default-target-valve.xml >> Log: >> - Added a test for the mapping of a pipeline XML description to a pipeline >> object using the mapper in stratum. >> >> 1.1 >> jakarta-turbine-3/src/test/org/apache/turbine/pipeline/classic-turbine-pipeli >> ne.xml >> >> Index: classic-turbine-pipeline.xml >> =================================================================== >> <pipeline> >> <name>ClassicTurbinePipeline</name> >> <valveDefinitions> >> <valveDefinition id="default-action-valve"/> >> <valveDefinition id="default-target-valve"/> >> </valveDefinitions> >> </pipeline> >> >> >> >> 1.1 >> jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-action-valve.x >> ml >> >> Index: default-action-valve.xml >> =================================================================== >> <valveDefinition> >> <name>DefaultActionValve</name> >> <className>org.apache.turbine.pipeline.DefaultActionValve</className> >> </valveDefinition> >> >> >> >> 1.1 >> jakarta-turbine-3/src/test/org/apache/turbine/pipeline/default-target-valve.x >> ml >> >> Index: default-target-valve.xml >> =================================================================== >> <valveDefinition> >> <name>DefaultTargetValve</name> >> <className>org.apache.turbine.pipeline.DefaultTargetValve</className> >> </valveDefinition> > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- jvz. Jason van Zyl http://tambora.zenplex.org http://jakarta.apache.org/turbine http://jakarta.apache.org/velocity http://jakarta.apache.org/alexandria http://jakarta.apache.org/commons -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
