I just finished fixing the keyword substitution code in org.apache.maven.jrcs.rcs.Archive.
I added a JUnit test for it. Substitutions that involve dates are currently no_ being tested because I lacked the time to do it well right now (how do we handle TODOs?). Check-ins of text with keywords substituted work correctly: Archive removes the keyword values before comparing the text to the head revision. Jason already took care of removing GNU regexp. About JRCS: JRCS is a library that knows how to manipulate the archive files produced by RCS and CVS. JRCS is not intended to replace neither tool(its minuscule test suite should be a clue into that). JRCS was written to be able create archive analysis tools (identify hot spots in the source code, measure the contributions by each developer, assess how bugs make it in, and that kind of stuff). The reason why I added the ability to do check-ins to JRCS was to provide symmetry, and to simplify the writing of unit tests. CAVEAT UTILITOR: Do not make modifications to your archives with JRCS. There needs to be an important amount of additional testing before it's safe to do that. Juanco > -----Original Message----- > From: Juancarlo A�ez [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, February 26, 2002 9:30 AM > To: Turbine Developers List > Subject: CVS variable substitution in JRCS > > > > You guys are moving too fast for me. I haven't had the time to follow = > the list yet.=20 > > I offered Jason I'd replace the references to GNU regexp with ones to = > Jakarta regexp (ORO is verkill). I can also take a look at the varable = > substitution code, but I need some time. > > Juanco > -- > Eng. Juancarlo A=F1ez > mailto:[EMAIL PROTECTED] > http://www.suigeneris.org/juanca/ > ---=20 > > > -----Original Message----- > > From: Stephane Bailliez [mailto:[EMAIL PROTECTED]] > > Sent: Monday, February 25, 2002 5:36 AM > > To: Turbine Developers List > > Subject: RE: cvs commit: > > jakarta-turbine-maven/src/java/org/apache/maven/jrcs/rcs Archive.java > >=20 > >=20 > > mmm ? I don't really understand what you imply here. > > More simply why isn't this "$Header$" (okay this is compiled directly = > this > > way) ? :) > >=20 > > If the original author can enlighten us about this part that=20 > > would be nice, > > I was ready to refactor all this in an ArchiveFormat.format() and > > ArchiveFormat.clean() and move to Oro instead of gnu.regex but I'm = > kind of > > lost about the substitution here. I'm 99% sure it is wrong but=20 > > need feedback > > to be sure at 100%. -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
